Skip to content

Make getDataProvider to reduce export duplicate code#39966

Open
indykoning wants to merge 2 commits intomagento:2.4-developfrom
indykoning:public-filter-getmetadataprovider
Open

Make getDataProvider to reduce export duplicate code#39966
indykoning wants to merge 2 commits intomagento:2.4-developfrom
indykoning:public-filter-getmetadataprovider

Conversation

@indykoning
Copy link
Copy Markdown
Contributor

@indykoning indykoning commented Jun 6, 2025 •
edited by m2-assistant Bot
Loading

Description (*)

This PR makes getDataProvider on the massaction public.
Why do we want this? To reduce unnecessary duplicate code. In the updated files you can see i've been able to remove prepareComponent.

This is because getDataProvider literally calls that when called and no dataProvider has been cached yet.

The call under there applySelectionOnTargetProvider actually calls getDataProvider as well. This means before this PR prepareComponent was always called twice during an export. Simply because we couldn't call getDataProvider and be sure prepareComponent was called.

Manual testing scenarios (*)

  1. Run an export from the Magento backend with filters and selections on/off, check if it still works as expected.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Make getDataProvider to reduce export duplicate code #39976: Make getDataProvider to reduce export duplicate code

@m2-assistant
Copy link
Copy Markdown

m2-assistant Bot commented Jun 6, 2025

Hi @indykoning. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@engcom-Hotel
Copy link
Copy Markdown
Contributor

engcom-Hotel commented Jun 10, 2025

@magento create issue

@m2-assistant m2-assistant Bot mentioned this pull request Jun 10, 2025
Open
5 tasks
@engcom-Hotel engcom-Hotel added Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it Priority: P3 May be fixed according to the position in the backlog. labels Jun 10, 2025
@github-project-automation github-project-automation Bot moved this to Pending Review in Pull Requests Dashboard Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Priority: P3 May be fixed according to the position in the backlog. Progress: pending review Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Projects

Pull Requests Dashboard
Status: Pending Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Issue] Make getDataProvider to reduce export duplicate code

2 participants

@indykoning @engcom-Hotel